fix(sentry): Filter UserInputError from Sentry - #1216
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b1138dc. Configure here.
| firstException?.type === "ConfigurationError" | ||
| ) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
Config errors silently dropped from Sentry
High Severity
Filtering all ConfigurationError events in sentryBeforeSend also drops the intentional logIssue calls from formatServerConfigError on HTTP transport. Those alerts notify operators about server-side config failures, and the generic user message claims the operator was notified.
Reviewed by Cursor Bugbot for commit b1138dc. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where expected
UserInputErrorandConfigurationErrorexceptions, particularly those originating fromparseIssueIddue to invalid input, were being captured and sent to Sentry as issues.These errors represent user-facing validation failures rather than actual bugs in the application, leading to noise in Sentry.
The fix modifies the
sentryBeforeSendfunction inpackages/mcp-core/src/telem/sentry.tsto check forUserInputErrorandConfigurationErrortypes. If an event's primary exception is one of these types,sentryBeforeSendnow returnsnull, preventing the event from being sent to Sentry.Fixes MCP-SERVER-G40
Comment
@sentry <feedback>on this PR to have Autofix iterate on the changes.